linux-kernel - Re: [RFC][PATCH] crypto: disable tests when they are not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100524122050.GB27432@shisha.kicks-ass.net>
Date:	Mon, 24 May 2010 15:20:50 +0300
From:	Alexander Shishkin <virtuoso@...nd.org>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [RFC][PATCH] crypto: disable tests when they are not enabled

On Mon, May 24, 2010 at 09:27:26 +1000, Herbert Xu wrote:
> On Mon, May 24, 2010 at 12:35:24PM +0300, Alexander Shishkin wrote:
> > Don't compile in and don't schedule cryptomanager's tests when
> > CONFIG_CRYPTO_TESTS is not set. This saves quite some time during
> > kernel initialization.
> 
> You're disabling the self-testing infrastructure.  This is not
> the same thing as the tcrypt module.

It is my intention to disable these tests since in my running them at
every boot doesn't add any value. I thought about adding a separate
Kconfig option for that, too. I want to make sure it's a sensible thing
to do.

> Is this for fast booting?

Yes, it saves ~180 miliseconds for me at prng_mod_init(), for example.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/