linux-kernel - Re: [PATCH -next] nouveau: fix acpi_lid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100524135940.GA15892@srcf.ucam.org>
Date:	Mon, 24 May 2010 14:59:40 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Ben Skeggs <bskeggs@...hat.com>,
	dri-devel@...ts.freedesktop.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH -next] nouveau: fix acpi_lid_open undefined

On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote:
> On 05/24/10 05:56, Matthew Garrett wrote:
> > Won't this result in a behavioural difference? The desirable outcome is 
> 
> It could, yes.
> 
> > that that configuration be impossible, not for that configuration to 
> > build but be buggy.
> 
> so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON?

There's an argument that it doesn't need to depend on it, but if button 
is a module then nouveau has to be. Except the inverse isn't true. 
Kconfig is hard, let's weep gently.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/