linux-kernel - Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path with name_to_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik8F43_4SRkH7XpfX5CTQ-xQ_8f3_yJTjDqSulU@mail.gmail.com>
Date:	Mon, 24 May 2010 09:44:07 -0500
From:	Will Drewry <wad@...omium.org>
To:	agk@...hat.com
Cc:	linux-kernel@...r.kernel.org, snitzer@...hat.com,
	dm-devel@...hat.com
Subject: Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path with 
	name_to_dev_t

On Mon, May 24, 2010 at 6:38 AM, Alasdair G Kergon <agk@...hat.com> wrote:
> I'll apply this, [snip]

Thanks!

On Mon, May 24, 2010 at 6:57 AM, Alasdair G Kergon <agk@...hat.com> wrote:
> On Wed, May 19, 2010 at 01:38:24PM -0500, Will Drewry wrote:
>> +     char base_path[32];  /* size from name_to_dev_t */
>
>> +     /* stage the shorter path for name_to_dev_t. */
>> +     strncpy(base_path, path, sizeof(base_path));
>
> I'm dropping that, and just passing path directly, so the strlen test
> will be used.  (There's a "name += 5" in there so 32 would ignore
> any longer standard names anyway.)

Sounds good.  And nice catch on the truncation with 32 - in an
attempt to minimize the extra copying, I went a bit too far!

fwiw, the only reason for the copy was because |path| is a
const in the function but not when passed to name_to_dev_t.
I wasn't sure what the preferred practice was so I just duped
the data needed.

cheers!
will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/