[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100524172237.7c17cd57@bike.lwn.net>
Date: Mon, 24 May 2010 17:22:37 -0600
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab@...hat.com>
Cc: linux-kernel@...r.kernel.org, Harald Welte <laforge@...monks.org>,
linux-fbdev@...r.kernel.org, JosephChan@....com.tw,
ScottFang@...tech.com.cn,
Bruno Prémont <bonbons@...ux-vserver.org>,
Florian Tobias Schandinat <FlorianSchandinat@....de>,
linux-media@...r.kernel.org
Subject: Re: [PATCH 5/5] Add the viafb video capture driver
On Sun, 23 May 2010 09:51:47 -0300
Mauro Carvalho Chehab <mchehab@...hat.com> wrote:
> The driver is OK to my eyes. I just found 2 minor coding style issues.
> it is ok to me if you want to sent it via your git tree.
>
> Acked-by: Mauro Carvalho Chehab <mchehab@...hat.com>
Great, thanks for taking a look!
All of the precursor stuff is in mainline now, so it can go via whatever
path. I'll just go ahead and request a pull in the near future unless
somebody objects.
> > + .sizeimage = VGA_WIDTH*VGA_HEIGHT*2,
>
> CodingStyle: please use spaces between values/operators. Not sure why, but
> newer versions of checkpatch.pl don't complain anymore on some cases.
Interesting...for all of my programming life I've left out spaces around
multiplicative operators - a way of showing that they bind more tightly
than the additive variety. I thought everybody else did that too.
CodingStyle agrees with you, though; I'll append a patch fixing these up.
Learn something every day...
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists