linux-kernel - Re: [PATCH 07/14] syscalls: add ARCH_COMPAT_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 May 2010 17:05:42 +1000
From:	Ian Munsie <imunsie@....ibm.com>
To:	Jason Baron <jbaron@...hat.com>
Cc:	fweisbec <fweisbec@...il.com>, mingo <mingo@...e.hu>,
	rostedt <rostedt@...dmis.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	laijs <laijs@...fujitsu.com>, lizf <lizf@...fujitsu.com>,
	hpa <hpa@...or.com>, tglx <tglx@...utronix.de>,
	mhiramat <mhiramat@...hat.com>,
	"heiko.carstens" <heiko.carstens@...ibm.com>,
	benh <benh@...nel.crashing.org>, davem <davem@...emloft.net>,
	lethal <lethal@...ux-sh.org>,
	schwidefsky <schwidefsky@...ibm.com>,
	brueckner <brueckner@...ux.vnet.ibm.com>,
	"tony.luck" <tony.luck@...el.com>
Subject: Re: [PATCH 07/14] syscalls: add ARCH_COMPAT_SYSCALL_DEFINE()

Excerpts from Jason Baron's message of Wed Mar 17 04:46:42 +1100 2010:
<snip>
> +    SYSCALL_METADATA(syscall, compat_sys_##sname, x);    \
> +    asmlinkage long syscall(__SC_DECL##x(__VA_ARGS__))
> +#else
> +#define COMPAT_SYSCALL_DEFINEx(x, sname, ...)            \

I think that should be:
#define COMPAT_SYSCALL_DEFINEx(x, syscall, sname, ...)

To avoid breaking archs without compat syscalls.

Cheers,
-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/