linux-kernel - Re: [PATCH] staging: remove all code dependent on LINUX_VERSION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 May 2010 20:18:35 +0900
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: remove all code dependent on LINUX_VERSION_CODE

> diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
> index 4c86102..c52ff7c 100644
> --- a/drivers/staging/cxt1e1/hwprobe.c
> +++ b/drivers/staging/cxt1e1/hwprobe.c
> @@ -305,15 +305,9 @@ c4hw_attach_all (void)
>     error_flag = 0;
>     prep_hdw_info ();
>     /*** scan PCI bus for all possible boards */
> -#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
> -    while ((pdev = pci_get_device (PCI_VENDOR_ID_CONEXANT,
> -                                   PCI_DEVICE_ID_CN8474,
> -                                   pdev)))
> -#else
>     while ((pdev = pci_find_device (PCI_VENDOR_ID_CONEXANT,
>                                     PCI_DEVICE_ID_CN8474,
>                                     pdev)))
> -#endif
>     {
>         if (c4_hdw_init (pdev, found))
>             found++;

It should be the other way around.
(sorry my previous message crapped)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/