linux-kernel - Re: [patch] TTY/n_gsm: potential double lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100525134258.568a600f@linux.intel.com>
Date:	Tue, 25 May 2010 13:42:58 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] TTY/n_gsm: potential double lock

On Tue, 25 May 2010 11:37:17 +0200
Dan Carpenter <error27@...il.com> wrote:

> In gsm_dlci_data_kick() we call gsm_dlci_data_sweep() with the
> "gsm->tx_lock" held so we can't lock it again inside
> gsm_dlci_data_sweep().  I removed that lock from and added one to 
> gsmld_write_wakeup() instead.  The sweep function is only called from
> those two places.

Well spotted - I'm surprised that escaped as I've been using the code a
fair bit in that exact form. Not immediately obvious that the case
should be that hard to trigger.

> Signed-off-by: Dan Carpenter <error27@...il.com>

Acked-by: Alan Cox <alan@...ux.intel.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/