linux-kernel - Re: [tip:timers/urgent] timers: Fix slack calculation really

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1005251211470.3689@i5.linux-foundation.org>
Date:	Tue, 25 May 2010 12:12:52 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	arjan@...ux.intel.com, tglx@...utronix.de
cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/urgent] timers: Fix slack calculation really



On Tue, 25 May 2010, tip-bot for Thomas Gleixner wrote:
>  {
> -	unsigned long expires_limit, mask;
> +	unsigned long expires_limit, mask, now;
>  	int bit;
>  
>  	expires_limit = expires;
>  
> -	if (timer->slack > -1)
> +	if (timer->slack >= 0) {
>  		expires_limit = expires + timer->slack;
> -	else if (time_after(expires, jiffies)) /* auto slack: use 0.4% */
> -		expires_limit = expires + (expires - jiffies)/256;
> -
> +	} else {
> +		now = jiffies;

So this works, but I'd really suggest that you actually nest the 
declarations correctly too. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/