linux-kernel - RE: [PATCH]: hpilo: fix pointer warning in ilo_ccb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92D64232F2316045B18937D5C9996B152CD6C5BA90@GVW1144EXB.americas.hpqcorp.net>
Date:	Tue, 25 May 2010 22:16:10 +0000
From:	"Altobelli, David" <david.altobelli@...com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Prarit Bhargava <prarit@...hat.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>,
	"tony.camuso@...hat.com" <tony.camuso@...hat.com>
Subject: RE: [PATCH]: hpilo: fix pointer warning in ilo_ccb_setup

> Seems very wrong - writes to *dmp_pa will now scribble over 
> the `struct ccb_data'.

Yeah.  The dma_pa variable is used to track the physical 
address of the DMA memory, and it is written to the device.  
We don't want a kernel pointer, we want the actual physical addr,
plus the various offsets.

> Probably local variable dma_pa should have type dma_addr_t.

I feel like I tried that, and I had trouble setting or using
the send_fifobar/recv_fifobar variables.  But I probably
didn't try too hard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/