linux-kernel - Re: [PATCH 12/27] drivers/ieee1394: Use memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100525153244.73069b6a.akpm@linux-foundation.org>
Date:	Tue, 25 May 2010 15:32:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Julia Lawall <julia@...u.dk>,
	linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 12/27] drivers/ieee1394: Use memdup_user

On Sat, 22 May 2010 11:25:47 +0200
Stefan Richter <stefanr@...6.in-berlin.de> wrote:

> Julia Lawall wrote:
> > Use memdup_user when user data is immediately copied into the
> > allocated region.
> 
> Looks nice.  We won't apply janitorial updates to drivers/ieee1394
> anymore though, since it is made obsolete by drivers/firewire and to be
> removed sooner than later.  (I will post a proposed removal schedule
> today to make this better known.)

I don't see much point in declaring a moratorium against
drivers/ieee1394.  Perhaps that removal will never happen.  Perhaps
third parties will find reason to revert that removal and to continue
to maintain drivers/ieee1394.  Perhaps people will take code snippets
from drivers/ieee1394 and will move them into drivers/firewire.

The bottom line is that the patch improves the code.  And there ain't
nothing wrong with having better code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/