lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 25 May 2010 09:47:31 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	iceberg <iceberg@...ras.ru>, Alexey Dobriyan <adobriyan@...il.com>,
	Tejun Heo <tj@...nel.org>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Removed unused variable from hidraw_read

On Wed, 19 May 2010, Stefan Achatz wrote:

> Removed unused variable from hidraw_read.
> 
> Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net>
> ---
>  drivers/hid/hidraw.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
> index 6eadf1a..bfe1e26 100644
> --- a/drivers/hid/hidraw.c
> +++ b/drivers/hid/hidraw.c
> @@ -46,7 +46,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
>  {
>  	struct hidraw_list *list = file->private_data;
>  	int ret = 0, len;
> -	char *report;
>  	DECLARE_WAITQUEUE(wait, current);
>  
>  	mutex_lock(&list->read_mutex);
> @@ -84,7 +83,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
>  		if (ret)
>  			goto out;
>  
> -		report = list->buffer[list->tail].value;
>  		len = list->buffer[list->tail].len > count ?
>  			count : list->buffer[list->tail].len;
>  

Applied, good catch. Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists