linux-kernel - Re: [PATCH] led-class: set permissions on max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1274873285.16229.83.camel@rex>
Date:	Wed, 26 May 2010 12:28:05 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	John Lenz <lenz@...wisc.edu>
Subject: Re: [PATCH] led-class: set permissions on max_brightness file to
 0444

On Mon, 2010-05-17 at 08:48 +0800, Axel Lin wrote:
> max_brightness is not writable, thus set permissions to 0444.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/leds/led-class.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 69e7d86..2606600 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -74,7 +74,7 @@ static ssize_t led_max_brightness_show(struct device *dev,
>  
>  static struct device_attribute led_class_attrs[] = {
>  	__ATTR(brightness, 0644, led_brightness_show, led_brightness_store),
> -	__ATTR(max_brightness, 0644, led_max_brightness_show, NULL),
> +	__ATTR(max_brightness, 0444, led_max_brightness_show, NULL),
>  #ifdef CONFIG_LEDS_TRIGGERS
>  	__ATTR(trigger, 0644, led_trigger_show, led_trigger_store),
>  #endif

Queued in the leds tree, thanks.

Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/