linux-kernel - Re: [PATCH] writeback: fix non-integrity write-back

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100526132126.GN23411@kernel.dk>
Date:	Wed, 26 May 2010 15:21:27 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] writeback: fix non-integrity write-back

On Wed, May 26 2010, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> 
> This is a fix for commit 7c8a3554. Note, I only compile-tested
> this.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> ---
>  fs/fs-writeback.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index ea8592b..0242855 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -920,7 +920,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
>  		if (force_wait)
>  			work->args.sync_mode = args.sync_mode = WB_SYNC_ALL;
>  
> -		post_clear = WB_SYNC_ALL || args.sb_pinned;
> +		post_clear = args.sync_mode == WB_SYNC_ALL || args.sb_pinned;
>  
>  		/*
>  		 * If this isn't a data integrity operation, just notify

Auch, indeed that's a dumb bug. It wont have a huge effect, but it'll
serialize some operations that need not be.

I'll queue it up, with the issue that Christoph reported as well, then
both of these want to go upstream soon.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/