[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.1005261754390.23743@ask.diku.dk>
Date: Wed, 26 May 2010 17:54:55 +0200 (CEST)
From: Julia Lawall <julia@...u.dk>
To: Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 3/17] arch/mips/kernel: Add missing read_unlock
From: Julia Lawall <julia@...u.dk>
Add a read_unlock missing on the error path. Other ways of reaching
out_unlock have tasklist_lock unlocked.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression E1;
@@
* read_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* read_unlock(E1,...);
// </smpl>
Signed-off-by: Julia Lawall <julia@...u.dk>
---
I wasn't able to find what security_task_setscheduler actually does.
If it releases tasklist_lock in an error case, then ignire this patch.
arch/mips/kernel/mips-mt-fpaff.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c
index f5981c4..73581bf 100644
--- a/arch/mips/kernel/mips-mt-fpaff.c
+++ b/arch/mips/kernel/mips-mt-fpaff.c
@@ -86,8 +86,10 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
}
retval = security_task_setscheduler(p, 0, NULL);
- if (retval)
+ if (retval) {
+ read_unlock(&tasklist_lock);
goto out_unlock;
+ }
/* Record new user-specified CPU set for future reference */
p->thread.user_cpus_allowed = new_mask;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists