linux-kernel - Re: [PATCH] Add missing extern to heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100526183501.GA14969@x200.telecom.by>
Date:	Wed, 26 May 2010 21:35:01 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Sebastien JAN <s-jan@...com>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH] Add missing extern to heap_free declaration

On Wed, May 26, 2010 at 08:28:19PM +0200, Sebastien JAN wrote:
> heap_free() function is defined in lib/prio_heap.c

> --- a/include/linux/prio_heap.h
> +++ b/include/linux/prio_heap.h
> -void heap_free(struct ptr_heap *heap);
> +extern void heap_free(struct ptr_heap *heap);

This is totally unneeded.

In fact, externless prototypes are better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/