linux-kernel - Re: [PATCH] arch/tile: new multi-core architecture for Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF1161BF2B.C681A3D5-ON4825772F.000A9BAB-4825772F.000F0B04@sunplusct.com>
Date:	Wed, 26 May 2010 10:44:19 +0800
From:	liqin.chen@...plusct.com
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Chris Metcalf <cmetcalf@...era.com>,
	Ulrich Drepper <drepper@...il.com>, linux-arch@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Chen Liqin <liqin.chen@...plusct.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] arch/tile: new multi-core architecture for Linux

Arnd Bergmann <arnd@...db.de> 写于 2010-05-25 23:03:11:

> 
> > - You renamed __NR__llseek to __NR_llseek, which of course seems 
pretty
> > reasonable, but libc expects to see the former (both glibc and 
uclibc). 
> > Is it worth requiring non-standard libc code?  I may just add
> > __NR__llseek as an alias in my unistd.h for now.
> 
> That was probably just a mistake on my side. The only other
> architecture using the generic version so far is score, so
> maybe Chen Liqin can comment on how he dealt with this and
> if he depends on the definition now.
> 

When we port glibc to score arch, we fixed the llseek.c file,
remove the underscore before llseek. maybe it has compatible problems, 
but it work ok with score application.

34c34
<   return (loff_t) (INLINE_SYSCALL (_llseek, 5, fd, (off_t) (offset >> 
32),
---
>   return (loff_t) (INLINE_SYSCALL (llseek, 5, fd, (off_t) (offset >> 
32),


--
liqin