linux-kernel - RE: [PATCH 6/7] scsi: megaraid_sas - Add three times Online controller reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B6A08C587958942AA3002690DD4F8C3D06ADE3F@cosmail02.lsi.com>
Date:	Wed, 26 May 2010 15:08:48 -0600
From:	"Yang, Bo" <Bo.Yang@....com>
To:	Tomas Henzl <thenzl@...hat.com>,
	James Bottomley <James.Bottomley@...e.de>
CC:	"'linux-scsi@...r.kernel.org'" <linux-scsi@...r.kernel.org>,
	"'akpm@...l.org'" <akpm@...l.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"Daftardar, Jayant" <Jayant.Daftardar@....com>
Subject: RE: [PATCH 6/7] scsi: megaraid_sas - Add three times Online
 controller reset - V2

Tomas/James,

> Also descriptive subjects would be nice (parts I-III may do well for
> Lord of the Rings ... it's less useful for SCSI patches).
>   
>This is again a question for the original author. Bo?

I changed the description and resubmit them already.

Bo Yang



-----Original Message-----
From: Tomas Henzl [mailto:thenzl@...hat.com] 
Sent: Wednesday, May 26, 2010 11:48 AM
To: James Bottomley
Cc: Yang, Bo; 'linux-scsi@...r.kernel.org'; 'akpm@...l.org'; 'linux-kernel@...r.kernel.org'; Daftardar, Jayant
Subject: Re: [PATCH 6/7] scsi: megaraid_sas - Add three times Online controller reset - V2

On 05/25/2010 07:32 PM, James Bottomley wrote:
> On Tue, 2010-05-25 at 18:17 +0200, Tomas Henzl wrote:
>   
>> V2: I've cleaned up some coding style issues and removed a variable, the functionality shouldn't be changed
>>
>> Tomas
>>
>> If fw didn't raise the interrupt with the fw state change to driver and fw goes to failure state, driver
>> Will check the FW state in driver's timeout routine and issue the reset if need.  Driver will do the OCR upto three
>> Times until kill adapter.  Also driver will issue OCR before driver kill adapter even if fw in operational state.   
>>     
> So there's supposed to be a replacement for 3/7 (megaraid_sas - Online
> COntroller Reset (OCR) PART-III) as well, isn't there?
>   
Yes, I think there are some issues that could be removed, on the other side
it is mostly coding style related, so I think it could be accepted as it is.
I hope I could afterwards clean something up. (The patches as they are now don't
apply correctly on my system, it's maybe an issue with my mail reader.)
 

> Also descriptive subjects would be nice (parts I-III may do well for
> Lord of the Rings ... it's less useful for SCSI patches).
>   
This is again a question for the original author. Bo?

Tomas


> James
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>