linux-kernel - Re: [PATCH]: Fix checkstack warning in bunzip2 library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100526165511.b2c1198e.akpm@linux-foundation.org>
Date:	Wed, 26 May 2010 16:55:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, ebiederm@...ssion.com,
	vgoyal@...hat.com, mjg@...hat.com, arozansk@...hat.com,
	Phillip Lougher <phillip@...gher.demon.co.uk>
Subject: Re: [PATCH]: Fix checkstack warning in bunzip2 library

On Tue, 25 May 2010 18:37:48 -0400
Prarit Bhargava <prarit@...hat.com> wrote:

> Fix checkstack error:
> 
> lib/decompress_bunzip2.c: In function ___get_next_block___:
> lib/decompress_bunzip2.c:511: warning: the frame size of 1932 bytes is larger than 1024 bytes
> 
> byteCount, symToByte, and mtfSymbol cannot be declared static or allocated
> dynamically so place them in the bunzip_data struct.
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> 
> diff --git a/lib/decompress_bunzip2.c b/lib/decompress_bunzip2.c
> index a4e971d..81c8bb1 100644
> --- a/lib/decompress_bunzip2.c
> +++ b/lib/decompress_bunzip2.c
> @@ -107,6 +107,8 @@ struct bunzip_data {
>  	unsigned char selectors[32768];		/* nSelectors = 15 bits */
>  	struct group_data groups[MAX_GROUPS];	/* Huffman coding tables */
>  	int io_error;			/* non-zero if we have IO error */
> +	int byteCount[256];
> +	unsigned char symToByte[256], mtfSymbol[256];
>  };
>  
>  
> @@ -158,14 +160,16 @@ static int INIT get_next_block(struct bunzip_data *bd)
>  	int *base = NULL;
>  	int *limit = NULL;
>  	int dbufCount, nextSym, dbufSize, groupCount, selector,
> -		i, j, k, t, runPos, symCount, symTotal, nSelectors,
> -		byteCount[256];
> -	unsigned char uc, symToByte[256], mtfSymbol[256], *selectors;
> +		i, j, k, t, runPos, symCount, symTotal, nSelectors, *byteCount;
> +	unsigned char uc, *symToByte, *mtfSymbol, *selectors;
>  	unsigned int *dbuf, origPtr;
>  
>  	dbuf = bd->dbuf;
>  	dbufSize = bd->dbufSize;
>  	selectors = bd->selectors;
> +	byteCount = bd->byteCount;
> +	symToByte = bd->symToByte;
> +	mtfSymbol = bd->mtfSymbol;
>  
>  	/* Read in header signature and CRC, then validate signature.
>  	   (last block signature means CRC is for whole file, return now) */

hm, I'm not sure that checkstack warnings are very relevant in the
contexts where this code executes, but the change is clean enough and
squishing a warning is good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/