linux-kernel - Re: [PATCH] config CONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BFDC855.4030604@snapgear.com>
Date:	Thu, 27 May 2010 11:18:13 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Christoph Egger <siccegge@...fau.de>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, Greg Kroah-Hartman <gregkh@...e.de>,
	Greg Ungerer <gerg@...inux.org>,
	Thiago Farina <tfransosi@...il.com>,
	linux-kernel@...r.kernel.org, vamos@...informatik.uni-erlangen.de
Subject: Re: [PATCH] config CONSOLE

Hi Christoph,

Christoph Egger wrote:
> 	As part of the VAMOS[0] research project at the University of
> Erlangen we are looking at multiple integrity errors in linux'
> configuration system.
> 
> 	CONSOLE is such a generic term that maybe someone just
> expected this option exists. Or maybe it existed ages ago but I can't
> find any trace of it. Anyway that code has been dead for quite some
> time withoutanybody noticing so it's probably just unneeded.

As far as I can tell it comes from the old 2.0.x out-of-main-line
uClinux patches. But yes, dead and gone for quite some time.


> 	Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.

I am happy to apply to the m68knommu git tree for eventual pushing
to main-line from there.

Regards
Greg



> [0] http://vamos1.informatik.uni-erlangen.de/
> 
> ----
>>>From 4a3b6fda1bb3a229c7ea8ca8992ed2573f07e5ba Mon Sep 17 00:00:00 2001
> From: Christoph Egger <siccegge@...fau.de>
> Date: Wed, 26 May 2010 15:18:26 +0200
> Subject: [PATCH] There's no config CONSOLE
> 
> as there's no config CONSOLE (never has been as far as I can tell) and
> noone has ever missed that piece of code, it should be safe to remove
> it making the kernel a tiny bit less complex.
> 
> Signed-off-by: Christoph Egger <siccegge@...fau.de>
> ---
>  drivers/serial/68328serial.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
> index 3046386..193a242 100644
> --- a/drivers/serial/68328serial.c
> +++ b/drivers/serial/68328serial.c
> @@ -78,10 +78,6 @@ struct m68k_serial *m68k_consinfo = 0;
>  
>  #define M68K_CLOCK (16667000) /* FIXME: 16MHz is likely wrong */
>  
> -#ifdef CONFIG_CONSOLE
> -extern wait_queue_head_t keypress_wait; 
> -#endif
> -
>  struct tty_driver *serial_driver;
>  
>  /* number of characters left in xmit buffer before we ask for more */
> @@ -301,9 +297,5 @@ static void receive_chars(struct m68k_serial *info, unsigned short rx)
>  #endif /* CONFIG_MAGIC_SYSRQ */
>  			}
> - 			/* It is a 'keyboard interrupt' ;-) */
> -#ifdef CONFIG_CONSOLE
> -			wake_up(&keypress_wait);
> -#endif			
>  		}
>  
>  		if(!tty)


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/