linux-kernel - Re: [PATCH 6/6] Btrfs: do aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100527125952.GQ3108@think>
Date:	Thu, 27 May 2010 08:59:52 -0400
From:	Chris Mason <chris.mason@...cle.com>
To:	liubo <liubo2009@...fujitsu.com>
Cc:	Josef Bacik <josef@...hat.com>, linux-btrfs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] Btrfs: do aio_write instead of write

On Thu, May 27, 2010 at 11:06:54AM +0800, liubo wrote:
> On 05/22/2010 01:03 AM, Josef Bacik wrote:
> > In order for AIO to work, we need to implement aio_write.  This patch converts
> > our btrfs_file_write to btrfs_aio_write.  I've tested this with xfstests and
> > nothing broke, and the AIO stuff magically started working.  Thanks,
> >
> > Signed-off-by: Josef Bacik <josef@...hat.com>
> >   
> 
> Hi, Josef,
> 
> I've tested your patch(May 22) with my tools, and one case triggered a bug
> which made writev operation hang up, more information is followed.
> 
> - Steps to trigger it:
>   # mount /dev/sda8 /home/btrfsdisk -o nodatacow
>   # gcc direct-io.c -o direct-io
>   # ./direct-io O_DIRECT writev /home/btrfsdisk/testrw 4M

Thanks for sending along this test program and bug report.  We've fixed
a few bugs in the O_DIRECT patches, and this is working now.

The merged result is in the for-linus branch of the btrfs unstable tree.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/