linux-kernel - Re: [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100527131539.GA26198@localhost>
Date:	Thu, 27 May 2010 15:15:39 +0200
From:	Johan Hovold <jhovold@...il.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer
 dereference

Hi Julia, 

On Thu, May 27, 2010 at 02:37:39PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> The assignment seems completely unnecessary if mos7840_port is NULL.
> 
[...]
> ---
>  drivers/usb/serial/mos7840.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index f8424d1..585b7e6 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -730,7 +730,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
>  	mos7840_port = urb->context;
>  	if (!mos7840_port) {
>  		dbg("%s", "NULL mos7840_port pointer");
> -		mos7840_port->read_urb_busy = false;
>  		return;
>  	}

I stumbled over this one a couple of weeks ago. There a patch sitting in
Greg's queue already:

	http://thread.gmane.org/gmane.linux.usb.general/31668

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/