linux-kernel - Re: [PATCH 1/2] vfs: sanitize __d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1OHdOm-00017x-G8@pomaz-ex.szeredi.hu>
Date:	Thu, 27 May 2010 15:45:24 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	miklos@...redi.hu, viro@...iv.linux.org.uk,
	john.johansen@...onical.com, penguin-kernel@...ove.sakura.ne.jp,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] vfs: sanitize __d_path()

On Thu, 27 May 2010, Alexey Dobriyan wrote:
> Why would they want to do it (which means taking locks again and
> potential incoherence)?
> The information is right there, ship it upwards:
> 
> +       if (deleted)
> +               *deleted = 0;
>         spin_lock(&vfsmount_lock);
>         prepend(&end, &buflen, "\0", 1);
> -       if (d_unlinked(dentry) &&
> -               (prepend(&end, &buflen, " (deleted)", 10) != 0))
> -                       goto Elong;
> +       if (d_unlinked(dentry) && deleted)
> +               *deleted = 1;
> 
> "(deleted)" as interface sucks, we can't change it,
> at least, let's make in-kernel interface correct.
> 

Do you have any specific caller in mind?

The above will just result in extra code in most callers.  Better have
one function with does the old "(deleted)" thing, and one which
doesn't.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/