linux-kernel - Re: [PATCH] perf: fix use_browser infinite loop bug in annotate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100527145142.GJ9874@ghostprotocols.net>
Date:	Thu, 27 May 2010 11:51:42 -0300
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	paulus@...ba.org, davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com
Subject: Re: [PATCH] perf: fix use_browser infinite loop bug in annotate

Em Thu, May 27, 2010 at 02:50:01PM +0200, Stephane Eranian escreveu:
> This patch fixes an infinite loop problem with perf annotate when
> the TUI is not used. When the perfconfig file is not found use_browser
> remains at -1, when found and tui is disabled use_browser = 0. Thus the
> correct test for TUI is use_browser > 0.
> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>

Thanks, I'm applying this one and doing an audit of other uses, I know
of one more case reported by Frédéric that was fixed in a similar way.

> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 08278ed..96db524 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -343,7 +343,7 @@ find_next:
>  			continue;
>  		}
>  
> -		if (use_browser) {
> +		if (use_browser > 0) {
>  			key = hist_entry__tui_annotate(he);
>  			if (is_exit_key(key))
>  				break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/