[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <56b9c89c17c1a85886f6d1928349e35bbb48c856.1274926772.git.len.brown@intel.com>
Date: Wed, 26 May 2010 22:42:25 -0400
From: Len Brown <lenb@...nel.org>
To: x86@...nel.org, linux-pm@...ts.linux-foundation.org
Cc: linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>
Subject: [PATCH 2/8] cpuidle: add cpuidle_unregister_driver() error check
From: Len Brown <len.brown@...el.com>
When cpuidle_unregister_driver() is called with a driver
other than the one that was successfully registered, do nothing.
Previously we'd NULL-out the one that was registered.
But that required the callers to remember what this
routine already remembers. With this check, the callers
can be simplified.
Signed-off-by: Len Brown <len.brown@...el.com>
---
drivers/cpuidle/driver.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
index 2257004..30bcd44 100644
--- a/drivers/cpuidle/driver.c
+++ b/drivers/cpuidle/driver.c
@@ -49,7 +49,8 @@ void cpuidle_unregister_driver(struct cpuidle_driver *drv)
return;
spin_lock(&cpuidle_driver_lock);
- cpuidle_curr_driver = NULL;
+ if (drv == cpuidle_curr_driver)
+ cpuidle_curr_driver = NULL;
spin_unlock(&cpuidle_driver_lock);
}
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists