linux-kernel - Re: [PATCH 2/4] [tip:x86/mm] Set first MB as RW+NX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100527095546.bb1bb941.randy.dunlap@oracle.com>
Date:	Thu, 27 May 2010 09:55:46 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Siarhei Liakh <sliakh.lkml@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-next@...r.kernel.org,
	Arjan van de Ven <arjan@...radead.org>,
	James Morris <jmorris@...ei.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@....de>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 2/4] [tip:x86/mm] Set first MB as RW+NX

Hi,


On Thu, 27 May 2010 12:52:21 -0400 Siarhei Liakh wrote:

> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index 4814d35..6dbcb6f 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -123,6 +123,17 @@ config DEBUG_NX_TEST
>          and the software setup of this feature.
>          If in doubt, say "N"
> 
> +config DEBUG_SET_1ST_MB_RWNX
> +       bool "Set 1st MB of kernel space mapping as RW+NX"
> +       default n
> +       depends on X86
> +       ---help---
> +         This option helps to catch unintended modifications/execution of
> +         1st megabyte of kernel address space. Such protection may interfere
> +         with run-time code patching and legacy BIOS services residing within
> +         the 1st MB of physical address space.
> +         If in doubt, say "N".

Please spell out "first" instead of "1st" (all places in user-visible text).

and gmail is space-stuffing your patches (converting tabs to spaces).
Not good.  Are you using the gmail web interface for patches?
That won't work AFAIK.  You'll need to use a real mail client.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/