linux-kernel - Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1005271911590.5422@ask.diku.dk>
Date:	Thu, 27 May 2010 19:13:43 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	walter harms <wharms@....de>
Cc:	Dan Carpenter <error27@...il.com>,
	HighPoint Linux Team <linux@...hpoint-tech.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference

On Thu, 27 May 2010, walter harms wrote:

> 
> 
> Dan Carpenter schrieb:
> > On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
> >> If it is a problem to use 0 when host is NULL, then the code could be fixed
> >> in another way.
> >>
> > 
> > Yeah.  It seems like it would be better to give a clearly bogus number.
> > I would have said -1 but "scsi-1" looks normal so maybe something like 
> > 9999999?
> > 
> 
> lets spend some bytes:
> 
> 	
> 	if (host)
> 		dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
> 	else
> 		dprintk("scsi: no host, hptiop_probe failed\n");

dprintk is defined in hptiop.h as:

#if 0
#define dprintk(fmt, args...) do { printk(fmt, ##args); } while(0)
#else
#define dprintk(fmt, args...)
#endif

So unless someone adjusts the #if 0, there is no code.  I guess there is a 
danger that adding such an if would actually generate some code?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/