linux-kernel - Re: [PATCH v2 2/4] splice: direct_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1OHw0L-0001wD-Ii@pomaz-ex.szeredi.hu>
Date:	Fri, 28 May 2010 11:37:25 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Changli Gao <xiaosuo@...il.com>
CC:	axboe@...nel.dk, viro@...iv.linux.org.uk, mszeredi@...e.cz,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	xiaosuo@...il.com
Subject: Re: [PATCH v2 2/4] splice: direct_splice_actor() should not use pos in sd

On Wed, 26 May 2010, Changli Gao wrote:
> direct_splice_actor() should not use pos in sd
> 
> direct_splice_actor() shouldn't use sd->pos, as sd->pos is for file reading,
> file->f_pos should be used instead.
> 
> Signed-off-by: Changli Gao <xiaosuo@...il.com>

Acked-by: Miklos Szeredi <mszeredi@...e.cz>


> ----
>  fs/splice.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/fs/splice.c b/fs/splice.c
> index 9e52de5..eb602cb 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -1232,7 +1232,8 @@ static int direct_splice_actor(struct pipe_inode_info *pipe,
>  {
>  	struct file *file = sd->u.file;
>  
> -	return do_splice_from(pipe, file, &sd->pos, sd->total_len, sd->flags);
> +	return do_splice_from(pipe, file, &file->f_pos, sd->total_len,
> +			      sd->flags);
>  }
>  
>  /**
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/