linux-kernel - Re: [RFC] oom-kill: give the dying task a higher priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100528142048.GF5579@balbir.in.ibm.com>
Date:	Fri, 28 May 2010 19:50:48 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Minchan Kim <minchan.kim@...il.com>
Cc:	"Luis Claudio R. Goncalves" <lclaudio@...g.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	David Rientjes <rientjes@...gle.com>,
	Mel Gorman <mel@....ul.ie>, williams@...hat.com
Subject: Re: [RFC] oom-kill: give the dying task a higher priority

* MinChan Kim <minchan.kim@...il.com> [2010-05-28 23:06:23]:

> > I confess I failed to distinguish memcg OOM and system OOM and used "in
> > case of OOM kill the selected task the faster you can" as the guideline.
> > If the exit code path is short that shouldn't be a problem.
> > 
> > Maybe the right way to go would be giving the dying task the biggest
> > priority inside that memcg to be sure that it will be the next process from
> > that memcg to be scheduled. Would that be reasonable?
> 
> Hmm. I can't understand your point. 
> What do you mean failing distinguish memcg and system OOM?
> 
> We already have been distinguish it by mem_cgroup_out_of_memory.
> (but we have to enable CONFIG_CGROUP_MEM_RES_CTLR). 
> So task selected in select_bad_process is one out of memcg's tasks when 
> memcg have a memory pressure. 
>

We have a routine to help figure out if the task belongs to the memory
cgroup that cause the OOM. The OOM entry from memory cgroup is
different from a regular one. 

-- 
	Three Cheers,
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/