linux-kernel - Re: [PATCH] fs/compat_rw_copy_check_uvector: add missing compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49632811ri.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 28 May 2010 11:31:29 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/compat_rw_copy_check_uvector: add missing compat_ptr call

Heiko Carstens <heiko.carstens@...ibm.com> writes:

> From: Heiko Carstens <heiko.carstens@...ibm.com>
>
> A call to access_ok is missing a compat_ptr conversion. Introduced with
> b83733639a494d5f42fa00a2506563fbd2d3015d "compat: factor out
> compat_rw_copy_check_uvector from compat_do_readv_writev"
>
> fs/compat.c: In function 'compat_rw_copy_check_uvector':
> fs/compat.c:629: warning: passing argument 1 of '__access_ok' makes pointer from integer without a cast
>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>

Thanks for catching this.  I'm ashamed I missed the compiler warning.
:(

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/