lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 28 May 2010 18:13:16 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Александр Мурашов 
	<alex_mur_spb@...l.ru>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: 0001-This-is-a-patch-to-the-gen-devlist.c-file-that-fixes.patch

Am Freitag, 28. Mai 2010 16:13:39 schrieb Александр Мурашов:
> 
> This is my first patch.Do not judge me harshly, I'm just learning.

I am afraid the first segment creates invalid C.

In addition, even the rules of coding style have to be applied
with some common sense.  Otherwise the result is basically unreadable.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ