linux-kernel - Re: linux-next: build failure after merge of the final tree (leds tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100528101157.aff693f4.sfr@canb.auug.org.au>
Date:	Fri, 28 May 2010 10:11:57 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Richard Purdie <rpurdie@...ys.net>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjarke Istrup Pedersen <gurligebis@...too.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus <torvalds@...ux-foundation.org>
Subject: Re: linux-next: build failure after merge of the final tree (leds
 tree related)

Hi Richard,

On Fri, 28 May 2010 01:35:49 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Thu, 27 May 2010 14:07:24 +0100 Richard Purdie <rpurdie@...ys.net> wrote:
> >
> > On Thu, 2010-05-27 at 21:36 +1000, Benjamin Herrenschmidt wrote:
> > > On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> > > > 
> > > > drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> > > > drivers/leds/leds-net5501.c: In function 'soekris_init':
> > > > drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
> > > 
> > > Looks like something is missing an ifdef CONFIG_X86 :-)
> > 
> > Right, that driver/board is x86 only. I've pushed a fix.
> > 
> > > > Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> > > > driver for the Soekris net5501 board").  Presumably only tested on x86?
> > > > 
> > > > drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> > > > drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
> > > > 
> > > > Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> > > > leds-gpio: Change blink_set callback to be able to turn off blinking").
> > 
> > This error looks like its from Ben's patch, probably when openfirmware
> > is enabled. I've queued a fix for this too:
> > 
> > http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/commit/?id=a4b4433c511cf4361bb0afabba69e16632002d32
> 
> Great, thanks.

Except, of course, Linus has merged the broken tree without the fixes :-(

Oh, well.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped