linux-kernel - Re: [PATCH] VFIO driver: Non-privileged user level PCI drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100528163643.44b2f9c3.randy.dunlap@oracle.com>
Date:	Fri, 28 May 2010 16:36:43 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Tom Lyon" <pugs@...co.com>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	chrisw@...s-sol.org, joro@...tes.org, hjk@...utronix.de,
	mst@...hat.com, avi@...hat.com, gregkh@...e.de, aafabbri@...co.com,
	scofeldm@...co.com
Subject: Re: [PATCH] VFIO driver: Non-privileged user level PCI drivers

Hi,


On Fri, 28 May 2010 16:07:38 -0700 Tom Lyon wrote:

Missing diffstat -p1 -w 70:

 Documentation/vfio.txt         |  176 ++++++++
 MAINTAINERS                    |    7 
 drivers/Kconfig                |    2 
 drivers/Makefile               |    1 
 drivers/vfio/Kconfig           |    9 
 drivers/vfio/Makefile          |    5 
 drivers/vfio/vfio_dma.c        |  372 ++++++++++++++++++
 drivers/vfio/vfio_intrs.c      |  189 +++++++++
 drivers/vfio/vfio_main.c       |  627 +++++++++++++++++++++++++++++++
 drivers/vfio/vfio_pci_config.c |  554 +++++++++++++++++++++++++++
 drivers/vfio/vfio_rdwr.c       |  147 +++++++
 drivers/vfio/vfio_sysfs.c      |  153 +++++++
 include/linux/vfio.h           |  193 +++++++++
 13 files changed, 2435 insertions(+)


which shows that the patch is missing an update to
Documentation/ioctl/ioctl-number.txt for ioctl code ';'.  Please add that.


> diff -uprN linux-2.6.34/drivers/vfio/Kconfig vfio-linux-2.6.34/drivers/vfio/Kconfig
> --- linux-2.6.34/drivers/vfio/Kconfig	1969-12-31 16:00:00.000000000 -0800
> +++ vfio-linux-2.6.34/drivers/vfio/Kconfig	2010-05-27 17:07:25.000000000 -0700
> @@ -0,0 +1,9 @@
> +menuconfig VFIO
> +	tristate "Non-Priv User Space PCI drivers"

	          Non-privileged

> +	depends on PCI
> +	help
> +	  Driver to allow advanced user space drivers for PCI, PCI-X,
> +	  and PCIe devices.  Requires IOMMU to allow non-privilged

	                                             non-privileged

> +	  processes to directly control the PCI devices.
> +
> +	  If you don't know what to do here, say N.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/