linux-kernel - Re: Perf trace event parse errors for KVM events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1275139177.22648.610.camel@gandalf.stny.rr.com>
Date:	Sat, 29 May 2010 09:19:37 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	Stefan Hajnoczi <stefanha@...il.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, Frederic Weisbecker <fweisbec@...il.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com>
Subject: Re: Perf trace event parse errors for KVM events

On Sat, 2010-05-29 at 14:50 +0300, Avi Kivity wrote:
> On 05/29/2010 12:45 AM, Steven Rostedt wrote:
> > On Fri, 2010-05-28 at 17:42 +0100, Stefan Hajnoczi wrote:
> >    
> >> I get parse errors when using Steven Rostedt's trace-cmd tool, too.
> >>
> >> Any ideas what is going on here?  I can provide more info (e.g. trace
> >> files) if necessary.
> >>      
> > Does trace-cmd fail on the same tracepoints? Have you checkout the
> > latest code?.
> >
> > I do know it fails on some of the KVM tracerpoints since the formatting
> > they use is obnoxious.
> >
> >    
> 
> Isn't there a binary trace for this?
> 

The pretty printing from the kernel handles this fine. But there's
pressure to pass the format to userspace in binary and have the tool
parse it. Currently it uses the print fmt to figure out how to parse.

Using one of the examples that Stefan showed:

kvmmmu/kvm_mmu_get_page: print fmt: "%s %s", ({ const char *ret =
p->buffer + p->len; static const char *access_str[] = { "---", "--x",
"w--", "w-x", "-u-", "-ux", "wu-", "wux" }; union kvm_mmu_page_role
role; role.word = REC->role; trace_seq_printf(p, "sp gfn %llx %u%s q%u%s
%s%s" " %snxe root %u %s%c", REC->gfn, role.level, role.cr4_pae ? "
pae" : "", role.quadrant, role.direct ? " direct" : "",
access_str[role.access], role.invalid ? " invalid" : "", role.nxe ? "" :
"!", REC->root_count, REC->unsync ? "unsync" : "sync", 0); ret; }),
REC->created ? "new" : "existing"


You need a full C parser/interpreter to understand the above.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/