linux-kernel - Re: [git pull] vfs pile, part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100529090708.GA20606@infradead.org>
Date:	Sat, 29 May 2010 05:07:08 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Sage Weil <sage@...dream.net>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs pile, part 2

On Fri, May 28, 2010 at 08:47:53PM +0100, Al Viro wrote:
> My apologies, I thought you'd been Cc'd on the discussions with Ian concerning
> that stuff, but...
> 
> The bottom line: "autofs4: always use lookup for lookup" is needed for them
> and it had to be reverted since it'd been FUBAR.
> 
> Details: we really, *really* can not do things in ->d_revalidate() and count
> on ->lookup() to come and finish them.  Think for a minute and you'll see why -
> between these two calls we allocate a dentry to pass to ->lookup().  What
> happens if that allocation fails?
> 
> And without that patch your stuff breaks autofs4.  So it's waiting for the
> ->d_revalidate() interface redesign.  Hopefully in the coming cycle...

In addition to that autofs also needs either major surgery or to be
dropped.  If we want to do the latter we'd be better of to strongly
deprecate it now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/