linux-kernel - Re: [PATCH] panic: keep blinking in spite of long spin timer mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 30 May 2010 08:55:22 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	TAMUKI Shoichi <tamuki@...et.gr.jp>
Cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Anton Blanchard <anton@...ba.org>,
	Andy Green <andy@...mcat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] panic: keep blinking in spite of long spin timer mode

> Therefore, I changed to call panic_blink_enter() between every mdelay.
> The default time calls to mdelay is 1ms.  If the kernel parameter
> panic_longspin is set to true, it will be switched to 240ms and the
> maximum speed of blinking will be automatically limited slower due to
> the granularity of the blinking time.

Thanks for this explanation, makes all sense. 
But should do these changes by default then, not with a parameter.

Changing the frequency is ok, the only requirement is that it is
visible and different from the frequency kdb uses.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/