linux-kernel - Re: [PATCH] cgroup: alloc_css_id() increments hierarchy depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100531084529.2b1f0d25.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Mon, 31 May 2010 08:45:29 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Paul Menage <menage@...gle.com>
Cc:	Greg Thelen <gthelen@...gle.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ben Blum <bblum@...rew.cmu.edu>,
	containers@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: alloc_css_id() increments hierarchy depth

On Fri, 28 May 2010 15:25:08 -0700
Paul Menage <menage@...gle.com> wrote:

> On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen@...gle.com> wrote:
> >
> > Signed-off-by: Greg Thelen <gthelen@...gle.com>
> 
> Acked-by: Paul Menage <menage@...gle.com>
> 
> Good catch, thanks.
> 
Nice Catch.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

But, who breaks this ? Do we need backport this against old kernels ?

2.6.33 has this.
> 3959         depth = css_depth(parent_css) + 1;
> 3960         parent_id = parent_css->id;
> 3961 
> 3962         child_id = get_new_cssid(ss, depth);


Thanks,
-Kame


> Paul
> 
> > ---
> >  kernel/cgroup.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> > index 422cb19..3ac6f5b 100644
> > --- a/kernel/cgroup.c
> > +++ b/kernel/cgroup.c
> > @@ -4598,7 +4598,7 @@ static int alloc_css_id(struct cgroup_subsys *ss, struct cgroup *parent,
> >        parent_css = parent->subsys[subsys_id];
> >        child_css = child->subsys[subsys_id];
> >        parent_id = parent_css->id;
> > -       depth = parent_id->depth;
> > +       depth = parent_id->depth + 1;
> >
> >        child_id = get_new_cssid(ss, depth);
> >        if (IS_ERR(child_id))
> > --
> > 1.7.0.1
> >
> >
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/