linux-kernel - Re: [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1275179960.4825.1.camel@gandalf.stny.rr.com>
Date:	Sat, 29 May 2010 20:39:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	Miklos Szeredi <miklos@...redi.hu>, axboe@...nel.dk,
	Al Viro <viro@...iv.linux.org.uk>, mszeredi@...e.cz,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2 3/4]: sendfile: remove flags paramter of 
 do_splice_direct()

On Sun, 2010-05-30 at 07:58 +0800, Changli Gao wrote:
> On Sun, May 30, 2010 at 12:20 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> > [ Removed matthew@....cx since I'm getting errors in sending to that address ]
> >

> But why not use (file->f_flags & O_NONBLOCK) instead, as
> tracing_splice_read_pipe() does?

Probably because I copied the code from something that used
SPLICE_F_NONBLOCK ;-)

But userspace passes that flag too. Although, maybe I just don't
understand the API fully.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/