lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 May 2010 09:11:20 +0800 From: Li Zefan <lizf@...fujitsu.com> To: Tejun Heo <tj@...nel.org> CC: "Michael S. Tsirkin" <mst@...hat.com>, Oleg Nesterov <oleg@...hat.com>, Sridhar Samudrala <sri@...ibm.com>, netdev <netdev@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, Dmitri Vorobiev <dmitri.vorobiev@...ial.com>, Jiri Kosina <jkosina@...e.cz>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 3/3] vhost: apply cpumask and cgroup to vhost pollers Tejun Heo wrote: > Apply the cpumask and cgroup of the initializing task to the created > vhost poller. > > Based on Sridhar Samudrala's patch. > > Cc: Michael S. Tsirkin <mst@...hat.com> > Cc: Sridhar Samudrala <samudrala.sridhar@...il.com> > --- > drivers/vhost/vhost.c | 36 +++++++++++++++++++++++++++++++----- > 1 file changed, 31 insertions(+), 5 deletions(-) > > Index: work/drivers/vhost/vhost.c > =================================================================== > --- work.orig/drivers/vhost/vhost.c > +++ work/drivers/vhost/vhost.c > @@ -23,6 +23,7 @@ > #include <linux/highmem.h> > #include <linux/slab.h> > #include <linux/kthread.h> > +#include <linux/cgroup.h> > > #include <linux/net.h> > #include <linux/if_packet.h> > @@ -176,12 +177,30 @@ repeat: > long vhost_dev_init(struct vhost_dev *dev, > struct vhost_virtqueue *vqs, int nvqs) > { > - struct task_struct *poller; > - int i; > + struct task_struct *poller = NULL; > + cpumask_var_t mask; > + int i, ret = -ENOMEM; > + > + if (!alloc_cpumask_var(&mask, GFP_KERNEL)) > + goto out; > If we "goto out", we will end up calling kthread_stop(poller), but seems kthread_stop() requires the task_struct pointer != NULL. > poller = kthread_create(vhost_poller, dev, "vhost-%d", current->pid); > - if (IS_ERR(poller)) > - return PTR_ERR(poller); > + if (IS_ERR(poller)) { > + ret = PTR_ERR(poller); > + goto out; > + } > + > + ret = sched_getaffinity(current->pid, mask); > + if (ret) > + goto out; > + > + ret = sched_setaffinity(poller->pid, mask); > + if (ret) > + goto out; > + > + ret = cgroup_attach_task_current_cg(poller); > + if (ret) > + goto out; > > dev->vqs = vqs; > dev->nvqs = nvqs; > @@ -202,7 +221,14 @@ long vhost_dev_init(struct vhost_dev *de > vhost_poll_init(&dev->vqs[i].poll, > dev->vqs[i].handle_kick, POLLIN, dev); > } > - return 0; > + > + wake_up_process(poller); /* avoid contributing to loadavg */ > + ret = 0; > +out: > + if (ret) > + kthread_stop(poller); > + free_cpumask_var(mask); > + return ret; > } > > /* Caller should have device mutex */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists