linux-kernel - Re: [PATCH -next] hid: roccat modules interdependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1005311357540.28092@pobox.suse.cz>
Date:	Mon, 31 May 2010 13:58:02 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Stefan Achatz <erazor_de@...rs.sourceforge.net>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH -next] hid: roccat modules interdependencies

On Thu, 27 May 2010, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> hid-roccat-kone calls the hid-roccat module interfaces,
> so the former should depend on or select the latter to prevent
> build errors, like:
> 
> hid-roccat-kone.c:(.text+0x133ed2): undefined reference to `roccat_report_event'
> hid-roccat-kone.c:(.text+0x133fa8): undefined reference to `roccat_disconnect'
> hid-roccat-kone.c:(.text+0x1353be): undefined reference to `roccat_connect'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/hid/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20100527.orig/drivers/hid/Kconfig
> +++ linux-next-20100527/drivers/hid/Kconfig
> @@ -358,6 +358,7 @@ config HID_ROCCAT
>  config HID_ROCCAT_KONE
>  	tristate "Roccat Kone Mouse support"
>  	depends on USB_HID
> +	select HID_ROCCAT
>  	---help---
>  	Support for Roccat Kone mouse.

Applied, thanks Randy.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/