linux-kernel - Re: [PATCH] General fixes in the serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100531142122.GA2571@frolo.macqel>
Date:	Mon, 31 May 2010 16:21:23 +0200
From:	Philippe De Muyter <phdm@...qel.be>
To:	Claudio Scordino <claudio@...dence.eu.com>
Cc:	hskinnemoen@...el.com, Nicolas Ferre <nicolas.ferre@...el.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Bernhard Roth <br@...net.de>, Rick Bronson <rick@....org>,
	John Nicholls <john@...nlinx.com>,
	Sebastian Heutling <Sebastian.Heutling@...-ing.de>,
	Ryan Mallon <ryan@...ewatersys.com>,
	michael trimarchi <michael@...dence.eu.com>,
	Konrad Mattheis <mattheis@...a.de>,
	Elektrolot <elektrolot@...pl>,
	Prchal Jiří <jiri.prchal@...ignal.cz>,
	akpm@...ux-foundation.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux@...im.org.za
Subject: Re: [PATCH] General fixes in the serial_rs485 structure

On Mon, May 31, 2010 at 03:39:37PM +0200, Claudio Scordino wrote:

> diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c
> index eed3c2d..1adb1bf 100644
> --- a/drivers/serial/atmel_serial.c
> +++ b/drivers/serial/atmel_serial.c
> @@ -216,7 +216,7 @@ void atmel_config_rs485(struct uart_port *port, struct serial_rs485 *rs485conf)
>  	if (rs485conf->flags & SER_RS485_ENABLED) {
>  		dev_dbg(port->dev, "Setting UART to RS485\n");
>  		atmel_port->tx_done_mask = ATMEL_US_TXEMPTY;
> -		UART_PUT_TTGR(port, rs485conf->delay_rts_before_send);
> +		UART_PUT_TTGR(port, rs485conf->delay_rts_after_send);
>  		mode |= ATMEL_US_USMODE_RS485;
>  	} else {
>  		dev_dbg(port->dev, "Setting UART to RS232\n");

Should the usage of delay_rts_after_send not depend on
(flags & SER_RS485_RTS_AFTER_SEND) also ?

and likewise with delay_rts_before_send and SER_RS485_RTS_BEFORE_SEND ?

Philippe

-- 
Philippe De Muyter  phdm at macqel dot be  Tel +32 27029044
Macq Electronique SA  rue de l'Aeronef 2  B-1140 Bruxelles  Fax +32 27029077
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/