linux-kernel - Re: [PATCH] x86, hweight: Fix UML boot crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 May 2010 18:29:38 +0200
From:	Borislav Petkov <borislav.petkov@....com>
To:	Jeff Dike <jdike@...toit.com>
CC:	Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Toralf Förster <toralf.foerster@....de>,
	"user-mode-linux-devel@...ts.sourceforge.net" 
	<user-mode-linux-devel@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, hweight: Fix UML boot crash

From: Jeff Dike <jdike@...toit.com>
Date: Mon, May 31, 2010 at 11:56:19AM -0400

> On Mon, May 31, 2010 at 03:51:32PM +0200, Borislav Petkov wrote:
> > <arch/x86/include/asm/bitops.h> includes <asm/arch_hweight.h> which are
> > the optimized variants.
> 
> But how does UML get to arch/x86/include/asm/bitops.h in the first place?
> 
> It must go through an arch/um/include/asm/something.h (where something
> might be bitops) first, right?

Right, look at one of those dependencies file (for example,
arch/um/kernel/.ptrace.o.cmd) for a _very_ long inclusion chain which
contains <arch/x86/include/asm/arch_hweight.h> at some point.

-- 
Regards/Gruss,
Boris.

Operating Systems Research Center
Advanced Micro Devices, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/