linux-kernel - Re: [PATCH 12/27] drivers/ieee1394: Use memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C03EAAA.6050603@s5r6.in-berlin.de>
Date:	Mon, 31 May 2010 18:58:18 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Julia Lawall <julia@...u.dk>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 12/27] drivers/ieee1394: Use memdup_user

Julia Lawall wrote on 2010-05-22:
...
> --- a/drivers/ieee1394/video1394.c
> +++ b/drivers/ieee1394/video1394.c
> @@ -1045,14 +1045,9 @@ static long video1394_ioctl(struct file *file,
>  			if (get_user(qv, &p->packet_sizes))
>  				return -EFAULT;
>  
> -			psizes = kmalloc(buf_size, GFP_KERNEL);
> -			if (!psizes)
> -				return -ENOMEM;
> -
> -			if (copy_from_user(psizes, qv, buf_size)) {
> -				kfree(psizes);
> -				return -EFAULT;
> -			}
> +			psizes = memdup_user(qv, buf_size);
> +			if (IS_ERR(psizes))
> +				return PTR_ERR(psizes);
>  		}
>  
>  		spin_lock_irqsave(&d->lock,flags);

Committed to linux1394-2.6.git now, thanks.  (Because akpm said that it
is worth it regardless of video1394 being at its end of life.)
-- 
Stefan Richter
-=====-==-=- -=-= =====
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/