lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 May 2010 16:08:20 -0300 From: Flavio Leitner <fbl@...close.org> To: Cong Wang <amwang@...hat.com> Cc: linux-kernel@...r.kernel.org, Matt Mackall <mpm@...enic.com>, netdev@...r.kernel.org, bridge@...ts.linux-foundation.org, Andy Gospodarek <gospo@...hat.com>, Neil Horman <nhorman@...driver.com>, Jeff Moyer <jmoyer@...hat.com>, Stephen Hemminger <shemminger@...ux-foundation.org>, bonding-devel@...ts.sourceforge.net, Jay Vosburgh <fubar@...ibm.com>, David Miller <davem@...emloft.net> Subject: Re: [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices On Mon, May 31, 2010 at 01:56:52PM +0800, Cong Wang wrote: > Hi, Flavio, > > Please use the attached patch instead, try to see if it solves > all your problems. I tried and it hangs. No backtraces this time. The bond_change_active_slave() prints before NETDEV_BONDING_FAILOVER notification, so I think it won't work. Please, correct if I'm wrong, but when a failover happens with your patch applied, the netconsole would be disabled forever even with another healthy slave, right? fbl > > Thanks a lot! > > diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c > index ca142c4..2d1d594 100644 > --- a/drivers/net/netconsole.c > +++ b/drivers/net/netconsole.c > @@ -666,7 +666,8 @@ static int netconsole_netdev_event(struct notifier_block *this, > struct net_device *dev = ptr; > > if (!(event == NETDEV_CHANGENAME || event == NETDEV_UNREGISTER || > - event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN)) > + event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN || > + event == NETDEV_BONDING_FAILOVER)) > goto done; > > spin_lock_irqsave(&target_list_lock, flags); > @@ -682,6 +683,7 @@ static int netconsole_netdev_event(struct notifier_block *this, > /* Fall through */ > case NETDEV_GOING_DOWN: > case NETDEV_BONDING_DESLAVE: > + case NETDEV_BONDING_FAILOVER: > nt->enabled = 0; > break; > } -- Flavio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists