linux-kernel - Re: [RFC] oom-kill: give the dying task a higher priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikFk_HnZWPG0s_VrRkro2rruEc8OBX5KfKp_QdX@mail.gmail.com>
Date:	Mon, 31 May 2010 14:01:03 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	"Luis Claudio R. Goncalves" <lclaudio@...g.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	balbir@...ux.vnet.ibm.com, Oleg Nesterov <oleg@...hat.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	David Rientjes <rientjes@...gle.com>,
	Mel Gorman <mel@....ul.ie>, williams@...hat.com
Subject: Re: [RFC] oom-kill: give the dying task a higher priority

Hi, Kame.

On Mon, May 31, 2010 at 9:21 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@...fujitsu.com> wrote:
> On Fri, 28 May 2010 13:48:26 -0300
> "Luis Claudio R. Goncalves" <lclaudio@...g.org> wrote:
>>
>> oom-killer: give the dying task rt priority (v3)
>>
>> Give the dying task RT priority so that it can be scheduled quickly and die,
>> freeing needed memory.
>>
>> Signed-off-by: Luis Claudio R. Gonçalves <lgoncalv@...hat.com>
>>
>> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> index 84bbba2..2b0204f 100644
>> --- a/mm/oom_kill.c
>> +++ b/mm/oom_kill.c
>> @@ -266,6 +266,8 @@ static struct task_struct *select_bad_process(unsigned long *ppoints)
>>   */
>>  static void __oom_kill_task(struct task_struct *p, int verbose)
>>  {
>> +     struct sched_param param;
>> +
>>       if (is_global_init(p)) {
>>               WARN_ON(1);
>>               printk(KERN_WARNING "tried to kill init!\n");
>> @@ -288,6 +290,8 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
>>        * exit() and clear out its resources quickly...
>>        */
>>       p->time_slice = HZ;
>> +     param.sched_priority = MAX_RT_PRIO-10;
>> +     sched_setscheduler(p, SCHED_FIFO, &param);
>>       set_tsk_thread_flag(p, TIF_MEMDIE);
>>
>
> BTW, how about the other threads which share mm_struct ?

Could you elaborate your intention? :)

>
> Thanks,
> -Kame
>
>



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/