linux-kernel - Re: [PATCH] perf-record: Check correct pid when forking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100531212723.GH5157@nowhere>
Date:	Mon, 31 May 2010 23:27:26 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf-record: Check correct pid when forking

On Mon, May 31, 2010 at 11:18:18PM +0200, Borislav Petkov wrote:
> When forking the child to be traced, we should check the correct return
> value from fork() and not a local variable which is otherwise unused.
> 
> Signed-off-by: Borislav Petkov <bp@...en8.de>
> ---
>  tools/perf/builtin-record.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 9bc8905..dc3435e 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -503,7 +503,6 @@ static int __cmd_record(int argc, const char **argv)
>  {
>  	int i, counter;
>  	struct stat st;
> -	pid_t pid = 0;
>  	int flags;
>  	int err;
>  	unsigned long waking = 0;
> @@ -572,7 +571,7 @@ static int __cmd_record(int argc, const char **argv)
>  
>  	if (forks) {
>  		child_pid = fork();
> -		if (pid < 0) {
> +		if (child_pid < 0) {



Oops :)


Since I'm preparing some fixes for .35 in perf tools, I'm queuing this one
too.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/