linux-kernel - Re: [PATCH 2/5] KVM: MMU: split the operations of kvm_mmu_zap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C04C004.4060809@redhat.com>
Date:	Tue, 01 Jun 2010 11:08:36 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH 2/5] KVM: MMU: split the operations of kvm_mmu_zap_page()

On 06/01/2010 05:29 AM, Xiao Guangrong wrote:
>
>> How about passing the list as a parameter to prepare() and commit()?  If
>> the lifetime of the list is just prepare/commit, it shouldn't be a global.
>>
>>      
> Does below example code show your meaning correctly?
>
> +	struct list_head free_list = LIST_HEAD_INIT(&free_list);
>
> 	hlist_for_each_entry_safe(sp, node, nn, bucket, hash_link) {
> 		if (sp->gfn == gfn&&  !sp->role.direct
> 		&&  !sp->role.invalid) {
> 			pgprintk("%s: zap %lx %x\n",
> 				 __func__, gfn, sp->role.word);
> +			kvm_mmu_prepare_zap_page(kvm, sp,&free_list);
> 		}
> 	}
> +	kvm_mmu_commit_zap_page(kvm,&free_list);
>
>    

Yes.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/