linux-kernel - Re: [Uclinux-dist-devel] [PATCH] NOMMU: Add '[stack]' label to /proc/pid/maps output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim_XTH-vhUx1em50GvfBSA4_UhlSJqtP46wh8F9@mail.gmail.com>
Date:	Tue, 1 Jun 2010 16:52:02 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	David Howells <dhowells@...hat.com>,
	uclinux-dist-devel@...ckfin.uclinux.org, akpm@...ux-foundation.org,
	uclinux-dev@...inux.org, linux-kernel@...r.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH] NOMMU: Add '[stack]' label to 
	/proc/pid/maps output

On Tue, Jun 1, 2010 at 15:07, Linus Torvalds wrote:
> On Tue, 1 Jun 2010, David Howells wrote:
>> Add support to the NOMMU /proc/pid/maps file to show which mapping is the stack
>> of the original thread after execve.  This is largely based on the MMU code.
>
> Umm? The MMU code that we _reverted_?

to be fair, this patch was written a few kernel revisions ago and
you're referring to commit merged a few weeks ago ...

> It turns out to be totally useless, since people put stacks in various
> different places, and the values the kernel does see end up not even being
> the "real" stack top.
>
> See commit 34441427aab4bdb3069a4ffcda69a99357abcb2e.
>
> Just don't do it.

but i dont think we're talking the same thing.  that commit refers to
[threadstack].  afaict, [stack] is still in there.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/