linux-kernel - Re: [PATCH 14/21] drivers/parisc/iosapic.c: Remove unnecessary kzalloc cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100601210212.GA19544@lackof.org>
Date:	Tue, 1 Jun 2010 15:02:12 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, Kyle McMartin <kyle@...artin.ca>,
	Helge Deller <deller@....de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH 14/21] drivers/parisc/iosapic.c: Remove unnecessary
	kzalloc cast

On Mon, May 31, 2010 at 08:23:16PM -0700, Joe Perches wrote:
> Convert kzalloc to kcalloc
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Reviewed-by: Grant Grundler <grundler@...isc-linux.org>

thanks,
grant

> ---
>  drivers/parisc/iosapic.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
> index c768367..3e6f56c 100644
> --- a/drivers/parisc/iosapic.c
> +++ b/drivers/parisc/iosapic.c
> @@ -891,8 +891,8 @@ void *iosapic_register(unsigned long hpa)
>  	isi->isi_version = iosapic_rd_version(isi);
>  	isi->isi_num_vectors = IOSAPIC_IRDT_MAX_ENTRY(isi->isi_version) + 1;
>  
> -	vip = isi->isi_vector = (struct vector_info *)
> -		kzalloc(sizeof(struct vector_info) * isi->isi_num_vectors, GFP_KERNEL);
> +	vip = isi->isi_vector = kcalloc(isi->isi_num_vectors,
> +					sizeof(struct vector_info), GFP_KERNEL);
>  	if (vip == NULL) {
>  		kfree(isi);
>  		return NULL;
> -- 
> 1.7.0.3.311.g6a6955
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/