[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.2.00.1005312122240.3637@i5.linux-foundation.org>
Date: Mon, 31 May 2010 21:27:50 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Rusty Russell <rusty@...tcorp.com.au>
cc: Andrew Morton <akpm@...ux-foundation.org>,
Brandon Philips <brandon@...p.org>,
"Rafael J. Wysocki" <rjw@...k.pl>,
LKML <linux-kernel@...r.kernel.org>,
Jon Masters <jonathan@...masters.org>,
Tejun Heo <htejun@...il.com>,
Masami Hiramatsu <mhiramat@...hat.com>,
Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 2/2] module: fix bne2 "gave up waiting for init of module
libcrc32c"
On Mon, 31 May 2010, Linus Torvalds wrote:
>
> Which means that it then cannot clean up properly afterwards if an error
> happens in the middle.
Oh, I guess it doesn't matter. For the non-unload case, we don't even do
any module counts, so the fixup ends up being a no-op. So with the error
handling fixed (which your 2/2 did), I guess it's actually ok. I still
think it would be nice to have /proc/modules show the module dependencies
regardless of whether they can be unloaded or not, but that's really just
an oddity, maybe not a "bug" per se.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists