linux-kernel - Re: [PATCH] drivers: remove all i2c_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 May 2010 22:05:39 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Richard Purdie <rpurdie@...ys.net>
Cc:	Wolfram Sang <w.sang@...gutronix.de>, linux-i2c@...r.kernel.org,
	Jean Delvare <khali@...ux-fr.org>,
	George Joseph <george.joseph@...rview5.com>,
	Riku Voipio <riku.voipio@....fi>,
	Guillaume Ligneul <guillaume.ligneul@...il.com>,
	"Ben Dooks (embedded platforms)" <ben-linux@...ff.org>,
	Alessandro Rubini <rubini@...l.unipv.it>,
	Colin Leroy <colin@...ino.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Paul Gortmaker <p_gortmaker@...oo.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Greg Kroah-Hartman <gregkh@...e.de>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	linuxppc-dev@...abs.org, linux-media@...r.kernel.org,
	linux-mtd@...ts.infradead.org, rtc-linux@...glegroups.com,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

On Mon, May 31, 2010 at 10:48:32PM +0100, Richard Purdie wrote:
> On Mon, 2010-05-31 at 12:09 -0700, Dmitry Torokhov wrote:
> > On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote:
> > > I2C-drivers can use the clientdata-pointer to point to private data. As I2C
> > > devices are not really unregistered, but merely detached from their driver, it
> > > used to be the drivers obligation to clear this pointer during remove() or a
> > > failed probe(). As a couple of drivers forgot to do this, it was agreed that it
> > > was cleaner if the i2c-core does this clearance when appropriate, as there is
> > > no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
> > > This feature was added to the core with commit
> > > e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.
> > > 
> > > As there is no need anymore to clear the clientdata-pointer, remove all current
> > > occurrences in the drivers to simplify the code and prevent confusion.
> > > 
> > > Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> > > Cc: Jean Delvare <khali@...ux-fr.org>
> > > ---
> > > 
> > > Some more notes:
> > > 
> > > I waited for rc1 as I knew there were some drivers/patches coming along which
> > > needed to be processed, too.
> > > 
> > > I'd suggest that this goes via the i2c-tree, so we get rid of all occurences at
> > > once.
> > > 
> > 
> > Frankly I'd prefer taking input stuff through my tree with the goal of
> > .36 merge window just to minimize potential merge issues. This is a
> > simple cleanup patch that has no dependencies, so there is little gain
> > from doing it all in one go.
> 
> How about asking Linus to take this one now, then its done and we can
> all move on rather than queuing up problems for the next merge window?
> 

That should work.

Acked-by: Dmitry Torokhov <dtor@...l.ru>

> Acked-by: Richard Purdie <rpurdie@...ux.intel.com>
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/